On Sun, Mar 09, 2014 at 02:57:16AM +0000, Punnaiah Choudary Kalluri wrote: > Added EDAC support for reporting the ecc errors of zynq ddr controller. > The ddr ecc controller corrects single bit errors and detects double bit > errors > > Signed-off-by: Punnaiah Choudary Kalluri <punnaia@xxxxxxxxxx> > --- > .../devicetree/bindings/edac/zynq_edac.txt | 18 + > drivers/edac/Kconfig | 7 + > drivers/edac/Makefile | 1 + > drivers/edac/zynq_edac.c | 613 ++++++++++++++++++++ > 4 files changed, 639 insertions(+), 0 deletions(-) > create mode 100644 Documentation/devicetree/bindings/edac/zynq_edac.txt > create mode 100644 drivers/edac/zynq_edac.c > > diff --git a/Documentation/devicetree/bindings/edac/zynq_edac.txt b/Documentation/devicetree/bindings/edac/zynq_edac.txt > new file mode 100644 > index 0000000..c21ff83 > --- /dev/null > +++ b/Documentation/devicetree/bindings/edac/zynq_edac.txt > @@ -0,0 +1,18 @@ > +Zynq EDAC driver, it does reports the DDR ECC single bit errors that are > +corrected and double bit ecc errors that are detected by the DDR ECC controller. > +ECC support for DDR is available in half-bus width(16 bit) configuration only. > + > +Required properties: > +- compatible: Should be "xlnx,ps7-ddrc" or "xlnx,ps7-ddrc-1.00.a" Is this an or or a xor? For the former case, which is the most general, which can be used as a fallback? How about something like: - compatible: should contain: * "xlnx,ps7-ddrc-1.00.a" for <DESCRIPTION HERE> * "xlnx,ps7-ddrc" for any compatible variant Is there any need at all for the "xlnx,ps7-ddrc" string? The driver doesn't care about it. Cheers, Mark. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
