On 10 March 2014 05:37, Tomasz Figa <tomasz.figa@xxxxxxxxx> wrote: > Hi Rahul, > > Please see some minor comments below. > > > On 04.03.2014 12:12, Rahul Sharma wrote: >> >> Add macros which are used as Clock IDs in DT and clock file. >> It also adds the documentation for the exynos5260 clocks. >> >> Signed-off-by: Rahul Sharma <Rahul.Sharma@xxxxxxxxxxx> >> --- >> .../devicetree/bindings/clock/exynos5260-clock.txt | 55 +++++ >> include/dt-bindings/clk/exynos5260-clk.h | 233 >> ++++++++++++++++++++ >> 2 files changed, 288 insertions(+) >> create mode 100644 >> Documentation/devicetree/bindings/clock/exynos5260-clock.txt >> create mode 100644 include/dt-bindings/clk/exynos5260-clk.h > > > [snip] > > >> diff --git a/include/dt-bindings/clk/exynos5260-clk.h >> b/include/dt-bindings/clk/exynos5260-clk.h >> new file mode 100644 >> index 0000000..4dc20a8 >> --- /dev/null >> +++ b/include/dt-bindings/clk/exynos5260-clk.h > > > Please use dt-bindings/clock directory. > > >> @@ -0,0 +1,233 @@ >> +/* >> + * Copyright (c) 2013 Samsung Electronics Co., Ltd. >> + * >> + * This program is free software; you can redistribute it and/or modify >> + * it under the terms of the GNU General Public License version 2 as >> + * published by the Free Software Foundation. >> + * >> + * Provides Constants for Exynos5260 clocks. >> +*/ > > > nit: Misaligned star. > > >> + >> +#ifndef _DT_BINDINGS_CLK_EXYNOS5260_H >> +#define _DT_BINDINGS_CLK_EXYNOS5260_H >> + >> +/* >> + * Clock names: XXXXXX_YYYYY_ZZZZZ >> + * |------| |----| |----| >> + * cmu type IP > > > The alignment looks wrong. Also tabs should be used. > >> +*/ > > > nit: Misaligned star. > > >> + >> +/* list of clocks for CMU_TOP */ > > > nit: Please properly capitalize comments and end them with a dot, e.g. > > /* List of clocks for CMU_TOP. */ > >> +#define FIN_PLL 1 > > > nit: No tabs between #define and DEF_NAME, please. > I will fix them in v5. Regards, Rahul Sharma. > Best regards, > Tomasz -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
