RE: [PATCH 2/3] mmc: renesas_sdhi_internal_dmac: Add R7S9210 support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Geert,

On Wednesday, October 10, 2018, Geert Uytterhoeven wrote:
> Thanks for your patch!

Thanks for your review!


> > +/* RZ/A2 does not have this bit (not safe to set it) */
> 
> This comment confused me, as SDHI_INTERNAL_DMAC_ADRR_MODE_FIXED is
> set for RZ/A2.
> 
> s/this bit/the ADDR_MODE bit/?

OK, I see your point.

Maybe I just change it to this:

  /* RZ/A2 does not have ADRR_MODE bit */

As you can imagine, it does have this bit. And it worked fine from me. 
But the chip guys said they found something not right with it, so they 
removed it from the v1.0 Hardware Manual.


Chris





[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux