Hi Sergei, On Mon, Oct 8, 2018 at 8:04 PM Sergei Shtylyov <sergei.shtylyov@xxxxxxxxxxxxxxxxxx> wrote: > On 10/08/2018 07:40 PM, Geert Uytterhoeven wrote: > >>>> Describe THS/CIVM in the R8A77970 device trees. > >>>> Based on the original (and large) patches by Vladimir Barinov. > >>>> + 0 0xe6190100 0 0x38>; > >>> > >>> What about the CIVM status register? DT describes hardware, not driver > >>> limitations. > >> > >> I wasn't sure whether to put it into a separate "reg" tuple (which would confuse > >> the driver) or not. After looking into the manual again, I'm going to extend the > >> 2nd "reg" tuple... > > > > The CIVM Status Register indicates the chip internal voltage. > > As such it's not a per-channel property, and IMHO doesn't belong in the second > > tuple > > I was looking a the block diagrams (both in the chapters 10A and 10B) and I got a totally different impression... I stand corrected. So extending the second reg block is fine. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds