Re: [PATCH 1/3] drm/msm/dpu: clean up references of DPU custom bus scaling

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Sravanthi,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on robclark/msm-next]
[also build test ERROR on next-20181009]
[cannot apply to v4.19-rc7]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Sravanthi-Kollukuduru/Use-interconnect-API-in-MDSS-on-SDM845/20181008-203309
base:   git://people.freedesktop.org/~robclark/linux msm-next
config: arm-multi_v7_defconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (Debian 7.2.0-11) 7.2.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        GCC_VERSION=7.2.0 make.cross ARCH=arm 

All errors (new ones prefixed by >>):

   drivers/gpu//drm/msm/disp/dpu1/dpu_crtc.c: In function 'dpu_crtc_debugfs_state_show':
>> drivers/gpu//drm/msm/disp/dpu1/dpu_crtc.c:1458:7: error: 'i' undeclared (first use in this function)
     for (i = DPU_POWER_HANDLE_DBUS_ID_MNOC;
          ^
   drivers/gpu//drm/msm/disp/dpu1/dpu_crtc.c:1458:7: note: each undeclared identifier is reported only once for each function it appears in
>> drivers/gpu//drm/msm/disp/dpu1/dpu_crtc.c:1458:11: error: 'DPU_POWER_HANDLE_DBUS_ID_MNOC' undeclared (first use in this function); did you mean '_DPU_POWER_HANDLE_H_'?
     for (i = DPU_POWER_HANDLE_DBUS_ID_MNOC;
              ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
              _DPU_POWER_HANDLE_H_
>> drivers/gpu//drm/msm/disp/dpu1/dpu_crtc.c:1459:8: error: 'DPU_POWER_HANDLE_DBUS_ID_MAX' undeclared (first use in this function); did you mean 'DPU_POWER_HANDLE_DBUS_ID_MNOC'?
       i < DPU_POWER_HANDLE_DBUS_ID_MAX; i++) {
           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
           DPU_POWER_HANDLE_DBUS_ID_MNOC
>> drivers/gpu//drm/msm/disp/dpu1/dpu_crtc.c:1461:5: error: implicit declaration of function 'dpu_power_handle_get_dbus_name'; did you mean 'dpu_power_handle_register_event'? [-Werror=implicit-function-declaration]
        dpu_power_handle_get_dbus_name(i),
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
        dpu_power_handle_register_event
   cc1: some warnings being treated as errors

vim +1458 drivers/gpu//drm/msm/disp/dpu1/dpu_crtc.c

25fdd593 Jeykumar Sankaran 2018-06-27  1448  
25fdd593 Jeykumar Sankaran 2018-06-27  1449  static int dpu_crtc_debugfs_state_show(struct seq_file *s, void *v)
25fdd593 Jeykumar Sankaran 2018-06-27  1450  {
25fdd593 Jeykumar Sankaran 2018-06-27  1451  	struct drm_crtc *crtc = (struct drm_crtc *) s->private;
25fdd593 Jeykumar Sankaran 2018-06-27  1452  	struct dpu_crtc *dpu_crtc = to_dpu_crtc(crtc);
25fdd593 Jeykumar Sankaran 2018-06-27  1453  
25fdd593 Jeykumar Sankaran 2018-06-27  1454  	seq_printf(s, "client type: %d\n", dpu_crtc_get_client_type(crtc));
25fdd593 Jeykumar Sankaran 2018-06-27  1455  	seq_printf(s, "intf_mode: %d\n", dpu_crtc_get_intf_mode(crtc));
25fdd593 Jeykumar Sankaran 2018-06-27  1456  	seq_printf(s, "core_clk_rate: %llu\n",
25fdd593 Jeykumar Sankaran 2018-06-27  1457  			dpu_crtc->cur_perf.core_clk_rate);
25fdd593 Jeykumar Sankaran 2018-06-27 @1458  	for (i = DPU_POWER_HANDLE_DBUS_ID_MNOC;
25fdd593 Jeykumar Sankaran 2018-06-27 @1459  			i < DPU_POWER_HANDLE_DBUS_ID_MAX; i++) {
25fdd593 Jeykumar Sankaran 2018-06-27  1460  		seq_printf(s, "bw_ctl[%s]: %llu\n",
25fdd593 Jeykumar Sankaran 2018-06-27 @1461  				dpu_power_handle_get_dbus_name(i),
25fdd593 Jeykumar Sankaran 2018-06-27  1462  				dpu_crtc->cur_perf.bw_ctl[i]);
25fdd593 Jeykumar Sankaran 2018-06-27  1463  		seq_printf(s, "max_per_pipe_ib[%s]: %llu\n",
25fdd593 Jeykumar Sankaran 2018-06-27  1464  				dpu_power_handle_get_dbus_name(i),
25fdd593 Jeykumar Sankaran 2018-06-27  1465  				dpu_crtc->cur_perf.max_per_pipe_ib[i]);
25fdd593 Jeykumar Sankaran 2018-06-27  1466  	}
25fdd593 Jeykumar Sankaran 2018-06-27  1467  
25fdd593 Jeykumar Sankaran 2018-06-27  1468  	return 0;
25fdd593 Jeykumar Sankaran 2018-06-27  1469  }
25fdd593 Jeykumar Sankaran 2018-06-27  1470  DEFINE_DPU_DEBUGFS_SEQ_FOPS(dpu_crtc_debugfs_state);
25fdd593 Jeykumar Sankaran 2018-06-27  1471  

:::::: The code at line 1458 was first introduced by commit
:::::: 25fdd5933e4c0f5fe2ea5cd59994f8ac5fbe90ef drm/msm: Add SDM845 DPU support

:::::: TO: Jeykumar Sankaran <jsanka@xxxxxxxxxxxxxx>
:::::: CC: Sean Paul <seanpaul@xxxxxxxxxxxx>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Attachment: .config.gz
Description: application/gzip


[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux