On Fri, Mar 07, 2014 at 09:19:08AM +0000, Charles Keepax wrote: > On Fri, Mar 07, 2014 at 10:48:41AM +0800, Mark Brown wrote: > > On Thu, Mar 06, 2014 at 05:05:39PM +0000, Charles Keepax wrote: > > > It updated the device tree binding to require a "cs-gpio" property to be > > > specified on the spi controller node if chip selects will be given as > > > GPIOs per slave, rather than the controller having a dedicated internal > > > chip select pin. > > No, it doesn't - it's saying that if the device has a "cs-gpio" property > > then to use that as the chip select. It's not a boolean, it's a GPIO > > specifier. Looking at the code it looks like the intention is to search > > all children for a cs-gpio during the controller probe, it's possible > > that this isn't working correctly. > That is basically part of my question is the current setup doing > what it is intended to? The Samsung binding has controller-data > blocks on each of the slaves that specify the gpio for that > slave. Right, which is also clearly the intention of the code.
Attachment:
signature.asc
Description: Digital signature
