Hi, Daniel On Sat, Sep 29, 2018 at 9:17 PM <dwalker@xxxxxxxxxx> wrote: > > On Thu, Sep 27, 2018 at 07:55:08PM +0300, Maksym Kokhan wrote: > > Daniel Walker (7): > > add generic builtin command line > > drivers: of: ifdef out cmdline section > > x86: convert to generic builtin command line > > arm: convert to generic builtin command line > > arm64: convert to generic builtin command line > > mips: convert to generic builtin command line > > powerpc: convert to generic builtin command line > > > > When I originally submitted these I had a very good conversion with Rob Herring > on the device tree changes. It seemed fairly clear that my approach in these > changes could be done better. It effected specifically arm64, but a lot of other > platforms use the device tree integrally. With arm64 you can reduce the changes > down to only Kconfig changes, and that would likely be the case for many of the > other architecture. I made patches to do this a while back, but have not had > time to test them and push them out. Can you please share this patches? I could test them and use to improve this generic command line implementation. > In terms of mips I think there's a fair amount of work needed to pull out their > architecture specific mangling into something generic. Part of my motivation for > these was to take the architecture specific feature and open that up for all the > architecture. So it makes sense that the mips changes should become part of > that. This is really makes sense, and we have intentions to implement it afterward. It would be easier to initially merge this simple implementation and then develop it step by step. > The only changes which have no comments are the generic changes, x86, and > powerpc. Those patches have been used at Cisco for years with no issues. > I added those changes into my -next tree for a round of testing. Assuming there > are no issues I can work out the merging with the architecture maintainers. > As for the other changes I think they can be done in time, as long as the > generic parts of upstream the rest can be worked on by any of the architecture > developers. Thanks, Maksym
