Am 05.10.18 um 18:58 schrieb Rob Herring: > Convert Realtek SoC bindings to DT schema format using json-schema. YAML (2x) > > Cc: "Andreas Färber" <afaerber@xxxxxxx> > Cc: Mark Rutland <mark.rutland@xxxxxxx> > Cc: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx > Cc: devicetree@xxxxxxxxxxxxxxx > Signed-off-by: Rob Herring <robh@xxxxxxxxxx> > --- > .../devicetree/bindings/arm/realtek.txt | 22 ---------------- > .../devicetree/bindings/arm/realtek.yaml | 25 +++++++++++++++++++ > 2 files changed, 25 insertions(+), 22 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/arm/realtek.txt > create mode 100644 Documentation/devicetree/bindings/arm/realtek.yaml > > diff --git a/Documentation/devicetree/bindings/arm/realtek.txt b/Documentation/devicetree/bindings/arm/realtek.txt > deleted file mode 100644 > index 95839e19ae92..000000000000 > --- a/Documentation/devicetree/bindings/arm/realtek.txt > +++ /dev/null > @@ -1,22 +0,0 @@ > -Realtek platforms device tree bindings > --------------------------------------- > - > - > -RTD1295 SoC > -=========== > - > -Required root node properties: > - > - - compatible : must contain "realtek,rtd1295" > - > - > -Root node property compatible must contain, depending on board: > - > - - MeLE V9: "mele,v9" > - - ProBox2 AVA: "probox2,ava" > - - Zidoo X9S: "zidoo,x9s" > - > - > -Example: > - > - compatible = "zidoo,x9s", "realtek,rtd1295"; > diff --git a/Documentation/devicetree/bindings/arm/realtek.yaml b/Documentation/devicetree/bindings/arm/realtek.yaml > new file mode 100644 > index 000000000000..9e3bb3249c77 > --- /dev/null > +++ b/Documentation/devicetree/bindings/arm/realtek.yaml > @@ -0,0 +1,25 @@ > +# SPDX-License-Identifier: None What is the expected license for such bindings? You did not add such a line for actions.yaml. > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/bindings/arm/realtek.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Realtek platforms device tree bindings > + > +maintainers: > + - Andreas Färber <afaerber@xxxxxxx> > + > +description: |+ "|+"? > + RTD1295 SoC > + > +properties: > + $nodename: > + const: '/' > + compatible: > + items: > + - enum: > + - mele,v9 > + - probox2,ava > + - zidoo,x9s > + - const: realtek,rtd1295 > +... That does not look like a full "PATCH" yet? It also confuses me whether or when leading dashes are necessary - for Actions Semi "items" had one. I have preparations on my GitHub staging tree for three more SoCs, so we should prepare the structure to ease adding SoCs and avoid re-indenting patches - adding SoCs was much easier in the original flat text format. Please also consider for other vendors. Same comment as for Actions: We're losing a human description of the enum values. Regards, Andreas -- SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg)
