+Julien, Zhengxunli and Mason from Macronix Hi Yogesh, On Thu, 4 Oct 2018 06:51:41 +0000 Yogesh Narayan Gaur <yogeshnarayan.gaur@xxxxxxx> wrote: > Hi Vignesh, > > > -----Original Message----- > > From: Vignesh R [mailto:vigneshr@xxxxxx] > > Sent: Wednesday, October 3, 2018 10:26 PM > > To: Boris Brezillon <boris.brezillon@xxxxxxxxxxx>; Marek Vasut > > <marek.vasut@xxxxxxxxx>; Rob Herring <robh+dt@xxxxxxxxxx> > > Cc: Brian Norris <computersforpeace@xxxxxxxxx>; Yogesh Narayan Gaur > > <yogeshnarayan.gaur@xxxxxxx>; Linux ARM Mailing List <linux-arm- > > kernel@xxxxxxxxxxxxxxxxxxx>; linux-mtd@xxxxxxxxxxxxxxxxxxx; > > devicetree@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; Vignesh R > > <vigneshr@xxxxxx> > > Subject: [PATCH 1/3] mtd: spi-nor: Add Octal mode support for mt35xu512aba > > > > Micron's mt35xu512aba flash is an Octal flash that has x8 IO lines. It supports > > read/write over 8 IO lines simulatenously. Add support for Octal read mode for > > Micron mt35xu512aba. > > Unfortunately, this flash is only complaint to SFDP JESD216B and does not seem > > to support newer JESD216C standard that provides auto detection of Octal > > mode capabilities and opcodes. Therefore, this capability is manually added > > using new SPI_NOR_OCTAL_READ flag. > > > > Thanks for sending the patch-set of adding octal support. > If possible, can you share the MT35x datasheet? > > I also have the patch ready in which I have added support for Read (1-1-8 and 1-8-8) protocol and Write (1-1-8 and 1-8-8). > Also have added support of Octal in driver/spi/spi.c framework. > > IMO, we would collaborate our patches. Looks like we are of stepping on each others toes here (see this branch [1]). I guess it's not a problem if we agree on who is working on what. Yogesh, you already sent "spi: add flags for octal I/O data transfer" [3] which is only adding the new OCTAL flags but is not patching spi.c and spi-mem.c to take those new flags into account. Here is my version of this patch [2] (it's still missing an update of SPI_MEM_MAX_BUSWIDTH). Let me know what you want to do (rework your version to address the problem or take mine). Regarding other patches in [2], they're mainly here to add support for X-X-X and DTR modes and get the m25p80 logic integrated in spi-nor.c so that we can really check which NOR operations are supported by the SPI controller. Regards, Boris [1]https://github.com/bbrezillon/linux/commits/spi-nor/octo [2]https://github.com/bbrezillon/linux/commit/9854a8fdd23f64e79859fd07a71d4a1c57b812f2 [3]https://patchwork.ozlabs.org/patch/894916/
