Re: [PATCH v3 1/2] dt-bindings: media: Add Aspeed Video Engine binding documentation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 10/01/2018 08:08 AM, Joel Stanley wrote:
On Tue, 25 Sep 2018 at 21:27, Eddie James <eajames@xxxxxxxxxxxxx> wrote:
Document the bindings.

Signed-off-by: Eddie James <eajames@xxxxxxxxxxxxx>
---
  .../devicetree/bindings/media/aspeed-video.txt     | 26 ++++++++++++++++++++++
  1 file changed, 26 insertions(+)
  create mode 100644 Documentation/devicetree/bindings/media/aspeed-video.txt

diff --git a/Documentation/devicetree/bindings/media/aspeed-video.txt b/Documentation/devicetree/bindings/media/aspeed-video.txt
new file mode 100644
index 0000000..f1af528
--- /dev/null
+++ b/Documentation/devicetree/bindings/media/aspeed-video.txt
@@ -0,0 +1,26 @@
+* Device tree bindings for Aspeed Video Engine
+
+The Video Engine (VE) embedded in the Aspeed AST2400 and AST2500 SOCs can
+capture and compress video data from digital or analog sources.
+
+Required properties:
+ - compatible:         "aspeed,ast2400-video-engine" or
+                       "aspeed,ast2500-video-engine"
+ - reg:                        contains the offset and length of the VE memory region
+ - clocks:             clock specifiers for the syscon clocks associated with
+                       the VE (ordering must match the clock-names property)
+ - clock-names:                "vclk" and "eclk"
+ - resets:             reset specifier for the syscon reset associaated with
associated

Good catch, thanks.


+                       the VE
+ - interrupts:         the interrupt associated with the VE on this platform
+
+Example:
+
+video-engine@1e700000 {
+    compatible = "aspeed,ast2500-video-engine";
+    reg = <0x1e700000 0x20000>;
+    clocks = <&syscon ASPEED_CLK_GATE_VCLK>, <&syscon ASPEED_CLK_GATE_ECLK>;
+    clock-names = "vclk", "eclk";
Did you end up sending the clock patches out?

Yes,

https://lore.kernel.org/patchwork/patch/978979/
https://lore.kernel.org/patchwork/patch/978976/

Do I need to send them as a separate series?

Thanks,
Eddie


Cheers,

Joel

+    resets = <&syscon ASPEED_RESET_VIDEO>;
+    interrupts = <7>;
+};
--
1.8.3.1





[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux