> +phys_addr_t __init_memblock memblock_end_of_REG0(void) > +{ > + return (memblock.memory.regions[0].base + memblock.memory.regions[0].size); > +} No need for the braces. > + if (memblock.memory.cnt > 1) { > + zone_size[ZONE_NORMAL] = PFN_DOWN(memblock_start_of_REG1()) - min_low_pfn; > + zhole_size[ZONE_NORMAL] = PFN_DOWN(memblock_start_of_REG1()) - max_low_pfn; Please brake lines after 80 characters. > + pr_info("C-SKY: https://github.com/c-sky/csky-linux\n"); I don't think this belongs into the kernel log.