Re: [PATCH] ARM: dts: iwg20d-q7-dbcm-ca: Improve model string

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Sep 26, 2018 at 11:54:36AM +0000, Chris Paterson wrote:
> Hello Geert,
> 
> > From: devicetree-owner@xxxxxxxxxxxxxxx <devicetree-
> > owner@xxxxxxxxxxxxxxx> On Behalf Of Geert Uytterhoeven
> > Sent: 26 September 2018 12:41
> > 
> > Hi Chris,
> > 
> > On Wed, Sep 26, 2018 at 12:01 PM Chris Paterson
> > <chris.paterson2@xxxxxxxxxxx> wrote:
> > > Update the model string for this platform configuration and fix the
> > > grammar at the same time.
> > >
> > > This brings the syntax in line with the RZ/G1E iWave board.
> > >
> > > Signed-off-by: Chris Paterson <chris.paterson2@xxxxxxxxxxx>
> > > ---
> > > Perhaps this patch isn't really needed, but the current string annoys me.
> > >
> > > Patch applies cleanly to renesas-devel-20180925-v4.19-rc5.
> > > ---
> > >  arch/arm/boot/dts/r8a7743-iwg20d-q7-dbcm-ca.dts | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/arch/arm/boot/dts/r8a7743-iwg20d-q7-dbcm-ca.dts
> > > b/arch/arm/boot/dts/r8a7743-iwg20d-q7-dbcm-ca.dts
> > > index 0d006aea99da1b40..6811ddc4af6460ce 100644
> > > --- a/arch/arm/boot/dts/r8a7743-iwg20d-q7-dbcm-ca.dts
> > > +++ b/arch/arm/boot/dts/r8a7743-iwg20d-q7-dbcm-ca.dts
> > > @@ -11,7 +11,7 @@
> > >  #include "iwg20d-q7-dbcm-ca.dtsi"
> > >
> > >  / {
> > > -       model = "iW-RainboW-G20D-Q7 RZ/G1M based plus camera daughter
> > board";
> > > +       model = "iWave RainboW-G20D-Q7 RZ/G1M based board with camera
> > > + add-on";
> > >         compatible = "iwave,g20d", "iwave,g20m", "renesas,r8a7743";
> > > };
> > 
> > Perhaps you want to harmonize the other differences, too?
> >   - "iWave" vs. "iWave Systems",
> >   - "Q7" vs. "Qseven",
> >   - "iW-Rainbow" vs. "Rainbow".
> 
> Probably not a bad idea...

I lets see if we can make all these updates in one patch.
Accordingly I'm marking this one as "Changes Requested".



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux