Re: [PATCH 1/2 v3] drm/panel: Augment the TPO TPG110 bindings

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 25 Sep 2018 16:35:58 +0200, Linus Walleij wrote:
> The TPO TPG110 bindings were using the DPI bindings (popular
> in the fbdev subsystem) but this misses the finer points
> learned in the DRM subsystem.
> 
> We need to augment the bindings for proper DRM integration:
> the timings are expressed by the hardware, not put into the
> device tree. I.e. this hardware is self-describing and can
> report the resolutions and timings needed. It should not
> be described in the device tree.
> 
> Further the device was incorrectly modeled with GPIO lines
> instead of an SPI child, even though the device was using
> SPI.
> 
> No known deployments of the device using device tree
> exist, so it should be fine to augment the bindings.
> 
> Cc: devicetree@xxxxxxxxxxxxxxx
> Signed-off-by: Linus Walleij <linus.walleij@xxxxxxxxxx>
> ---
> ChangeLog v2->v3:
> - Rewrite to reflect the fact that the display should be
>   an SPI child device using 3WIRE SPI.
> ChangeLog v1->v2:
> - Expand some sections to make it clear what kind of device
>   this is and that the serial protocol it uses is not
>   I2C.
> ---
>  .../bindings/display/panel/tpo,tpg110.txt     | 83 ++++++++++++-------
>  1 file changed, 54 insertions(+), 29 deletions(-)
> 

Reviewed-by: Rob Herring <robh@xxxxxxxxxx>



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux