* Grygorii Strashko <grygorii.strashko@xxxxxx> [180927 19:16]: > On 09/26/2018 06:31 PM, Tony Lindgren wrote: > > > > OK. So looks like the other i2c bus drivers have already solved it > > with simply SET_NOIRQ_SYSTEM_SLEEP_PM_OPS which is along the lines > > you're suggesting. > > > > The following works for me, does it look OK to you? > > it looks good, just curious if it will work both ti-sysc legacy/nonlegacy modes. OK, yes it seems to pass my artificial test case without ti-sysc dts changes, see below. So I just sent the i2c-omap patch as: "[PATCH] i2c: omap: Use noirq system sleep pm ops to idle device for suspend" Regards, Tony 8< ----------- [ 70.509713] PM: suspend entry (deep) [ 70.509739] PM: Syncing filesystems ... done. [ 70.516785] Freezing user space processes ... (elapsed 0.001 seconds) done. [ 70.518746] OOM killer disabled. [ 70.518756] Freezing remaining freezable tasks ... (elapsed 0.001 seconds) done. [ 70.520393] Suspending console(s) (use no_console_suspend to debug) [ 70.532983] wlan0: deauthenticating from 42:04:7a:03:0b:78 by local choice (Reason: 3=DEAUTH_LEAVING) [ 70.589742] wlcore: down [ 70.590435] wlcore: down [ 70.672208] Disabling non-boot CPUs ... [ 70.672237] pm33xx pm33xx: PM: Successfully put all powerdomains to target state [ 70.694047] net eth0: initializing cpsw version 1.15 (0) [ 70.792216] Micrel KSZ9031 Gigabit PHY 4a101000.mdio:04: attached PHY driver [Micrel KSZ9031 Gigabit PHY] (mii_bus:p) [ 70.795548] net eth1: initializing cpsw version 1.15 (0) [ 70.902204] Micrel KSZ9031 Gigabit PHY 4a101000.mdio:05: attached PHY driver [Micrel KSZ9031 Gigabit PHY] (mii_bus:p) [ 71.007103] usb usb1: root hub lost power or was reset [ 71.007121] usb usb2: root hub lost power or was reset [ 71.322414] wlcore: PHY firmware version: Rev 8.2.0.0.236 [ 71.417839] wlcore: firmware booted (Rev 8.9.0.0.69) [ 71.444787] OOM killer enabled. [ 71.444799] Restarting tasks ... done. [ 71.461113] PM: suspend exit