Hi, On Wed, Sep 26, 2018 at 1:54 PM Ryan Case <ryandcase@xxxxxxxxxxxx> wrote: > > From: Girish Mahadevan <girishm@xxxxxxxxxxxxxx> > > Bindings for Qualcomm Quad SPI used on SoCs such as sdm845. > > Signed-off-by: Girish Mahadevan <girishm@xxxxxxxxxxxxxx> > Signed-off-by: Ryan Case <ryandcase@xxxxxxxxxxxx> > --- > > Changes in v3: > - Added generic compatible string in addition to specific SoC > > Changes in v2: > - Added commit text > - Removed invalid property > - Updated example to match sdm845 with attached spi-nor > > .../bindings/spi/qcom,spi-qcom-qspi.txt | 36 +++++++++++++++++++ > 1 file changed, 36 insertions(+) > create mode 100644 Documentation/devicetree/bindings/spi/qcom,spi-qcom-qspi.txt This looks good to me and change in v3 to add the SoC-specific string in addition to the more generic string identifying the IP block version matches my understanding of the correct things to do (as discussed in the v2 patch). Reviewed-by: Douglas Anderson <dianders@xxxxxxxxxxxx>
