On Mon, Sep 24, 2018 at 10:23:14PM +0200, Arnd Bergmann wrote: > On Tue, Sep 18, 2018 at 3:48 PM Guo Ren <ren_guo@xxxxxxxxx> wrote: > > > > - remove irq_mapping from smp.c to irq-driver > > - Add set_ipi_irq_mapping api to irq-driver > > - update asm/smp.h > > > > Signed-off-by: Guo Ren <ren_guo@xxxxxxxxx> > > The patch seems ok to me, but please try to improve the changelog comments. > Generally speaking, use full English sentences instead of an enumerated list, > and explain what the change is for rather than what you are doing. The text Ok, I'll improve it. > you have here can easily be derived from looking at the code changes, > but I still don't understand what caused you to change it, and why this > is better than the previous version. The changelog comment will change to: There are some feedbacks from irqchip, and we need to adjust "smp.c & smp.h" to match the csky_mptimer modification. - Move IPI_IRQ define into drivers/irqchip/csky_mpintc.c, because it's a interrupt controller specific. - Bugfix request_irq with IPI_IRQ, we must use irq_mapping return value not directly use IPI_IRQ. The modification also involves csky_mpintc. Best Regards Guo Ren
