On 9/24/18 1:57 PM, Thierry Reding wrote: > On Mon, Sep 24, 2018 at 03:41:50AM +0300, Dmitry Osipenko wrote: >> GART became a part of Memory Controller, hence now the drivers device >> is Memory Controller and not GART. As a result all printed messages are >> prepended with the "tegra-mc 7000f000.memory-controller:", so let's >> prepend GART's messages with "GART:" in order to differentiate them >> from the MC. >> >> Signed-off-by: Dmitry Osipenko <digetx@xxxxxxxxx> >> --- >> drivers/iommu/tegra-gart.c | 36 ++++++++++++++++++------------------ >> 1 file changed, 18 insertions(+), 18 deletions(-) > > There's a macro called dev_fmt (similar to pr_fmt) to do this for dev_* > printers. Also I think this would be more readable if the prefix was > "gart: " rather than "GART: ". At least from my personal experience I > get easily distracted by all-caps words in logs, because they usually > indicate something that requires immediate attention. I think it's > better to leave that up to higher level mechanisms, such as the color > keying of messages based on level by tools like dmesg. The dev_fmt is a new thing, thank you for pointing at it. I'll try to switch to dev_fmt and lower the text case.
