Hi Krzysztof, On 2018-09-21 20:30, Krzysztof Kozlowski wrote: > The SDHCI standard, MMC host controller bindings and MMC core defines > card detect pin as active low. Therefore there is no point to invert it > twice. > > Signed-off-by: Krzysztof Kozlowski <krzk@xxxxxxxxxx> Works fine on TM2 and TM2e. However I'm not sure if it makes sense to refer to the SDHCI standard, as Exynos5433 has only DWMMC host controllers. Tested-by: Marek Szyprowski <m.szyprowski@xxxxxxxxxxx> > --- > arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi b/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi > index a1e3194b7483..86d8ddc3288a 100644 > --- a/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi > +++ b/arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi > @@ -939,8 +939,7 @@ > status = "okay"; > cap-sd-highspeed; > disable-wp; > - cd-gpios = <&gpa2 4 GPIO_ACTIVE_HIGH>; > - cd-inverted; > + cd-gpios = <&gpa2 4 GPIO_ACTIVE_LOW>; > card-detect-delay = <200>; > samsung,dw-mshc-ciu-div = <3>; > samsung,dw-mshc-sdr-timing = <0 4>; Best regards -- Marek Szyprowski, PhD Samsung R&D Institute Poland
