On 9/22/2018 10:07 PM, Sai Prakash Ranjan wrote:
On 9/22/2018 2:35 PM, Joel Fernandes wrote:
On Sat, Sep 8, 2018 at 4:28 PM Sai Prakash Ranjan
<saiprakash.ranjan@xxxxxxxxxxxxxx> wrote:
Also I think this spinlock can be moved further down.
OK. Something like this would suffice?
{{{
spin_lock_irqsave(&psinfo->buf_lock, flags);
record.buf = (char *)(seq->buffer);
record.size = seq->len;
psinfo->write(&record);
spin_unlock_irqrestore(&psinfo->buf_lock, flags);
}}}
If I move the spinlock further down like above, I get this backtrace:
[ 1.367708] console [pstore-1] enabled
[ 1.368874] pstore: Registered ramoops as persistent store backend
[ 1.372637] ramoops: attached 0x100000@0xbff00000, ecc: 0/0
[ 1.389382] WARNING: CPU: 2 PID: 2 at kernel/trace/trace_output.c:289
trace_raw_output_prep+0x18/0xa0
[ 1.389416] Modules linked in:
[ 1.397572] CPU: 2 PID: 2 Comm: kthreadd Not tainted
4.19.0-rc4-00032-g71e30ed20433-dirty #9
[ 1.409122] pstate: 80000005 (Nzcv daif -PAN -UAO)
[ 1.415804] pc : trace_raw_output_prep+0x18/0xa0
[ 1.420404] lr : trace_raw_output_sched_process_fork+0x1c/0x70
[ 1.425176] sp : ffff00000803bc00
[ 1.430815] x29: ffff00000803bc00 x28: ffff80003ca68d80
[ 1.434204] x27: ffff00000810d000 x26: 0000000000000001
[ 1.439586] x25: 0000000000000000 x24: ffff80000eb05090
[ 1.444881] x23: ffff80003ca68d80 x22: ffff00000803bd58
[ 1.450176] x21: ffff000009e63000 x20: ffff80003cbf8988
[ 1.455470] x19: ffff80000eb04000 x18: ffffffffffffffff
[ 1.460766] x17: 000000000006df2c x16: 0000000000000000
[ 1.466061] x15: ffff000009b496c8 x14: 0000000000000040
[ 1.471356] x13: ffffffffffffffff x12: 0000000000000000
[ 1.476651] x11: ffff80003c49a6a8 x10: 00000000000005d8
[ 1.481947] x9 : ffff80003c89f400 x8 : ffff00000803bc60
[ 1.487242] x7 : 0000000000000034 x6 : 0000000005d97d4a
[ 1.492536] x5 : 00ffffffffffffff x4 : 0000000000000050
[ 1.497831] x3 : 0000000000000056 x2 : ffff000009b657a0
[ 1.503127] x1 : ffff000009b657c0 x0 : ffff80000eb04000
[ 1.508422] Call trace:
[ 1.513716] trace_raw_output_prep+0x18/0xa0
[ 1.515890] pstore_event_call+0xbc/0x130
[ 1.520402] trace_event_buffer_commit+0xf8/0x248
[ 1.524308] trace_event_raw_event_sched_process_fork+0xc0/0xf8
[ 1.528999] _do_fork+0x234/0x418
[ 1.534724] kernel_thread+0x48/0x58
[ 1.538196] kthreadd+0x178/0x1f0
[ 1.541842] ret_from_fork+0x10/0x1c
[ 1.545052] ---[ end trace 97d58905d13e7aea ]---
[ 1.560654] s1: supplied by regulator-dummy
[ 1.560714] s1: Bringing 0uV into 375000-375000uV
--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation
