On Fri, Sep 21, 2018 at 11:28 AM Maxime Ripard <maxime.ripard@xxxxxxxxxxx> wrote: > Expanding a bit more that commit log would be helpful. What is the > eMMC connected to that board? Do all versions have it? Which modes are > supposed to be supported, and which one have been tested? The terseness of the commit message was already pointed out to me on #linux-sunxi. I was waiting for more comments before sending a v2. But you do touch on something I also realized: there are actually three versions of the A64-OLinuXino. In fact only one of them has the WiFi board, which is already enabled in the current device tree. Wouldn't it be better to split it into three separate device trees? I have made a patch that does that[1], if you think that is a good approach I can submit that as a patch and then later submit a patch on top of that to enable the eMMC only on the two boards that have it. I only have the A64-OLinuXino model that has both eMMC and WiFi. I have tested all three of the split device trees on it and they worked as expected. [1] https://github.com/RodrigoTjader/linux/commit/9f7cb025afbcb4b40d24c038fd976c7090d87d24
