Hello Vijay, On Wed, 19 Sep 2018 at 09:11, Vijay Khemka <vijaykhemka@xxxxxx> wrote: > Initial introduction of Facebook TiogaPass family equipped with > Aspeed 2500 BMC SoC. TiogaPass is a x86 server development kit > with a ASPEED ast2500 BMC manufactured by Facebook. > Specifically, This adds the tiogapass platform device tree file > including the flash layout used by the tiogapass BMC machines. > > This also adds an entry of tiogapass device tree file in Makefile > > Signed-off-by: Vijay Khemka <vijaykhemka@xxxxxx> It looks like you've addressed the concerns from previous reviews. If any comments come up please address them in follow up patches. I made some minor whitespace fixes and applied this to the aspeed v4.20 device tree branch. Cheers, Joel