On 2018/9/19 22:15, Timur Tabi wrote: > On 9/19/18 7:25 AM, Andrew Lunn wrote: >> ACPI is completely separate and should not affect the DT binding. >> I've not yet looked at the ACPI changes you added. > Just FYI, there is no device tree platform on which the upstream EMAC > driver works. All of the DT code in the driver is theoretical. It > worked once on a prototype platform, when I originally wrote the code, > but since then DT support is mostly a guess. > > The focus of any patches for the EMAC should be ACPI, not DT. If > anything, ACPI support should come first. No one should be writing or > reviewing DT code before ACPI code. > > The upstream EMAC driver is only known to work on the QDF2400, which is > an ACPI-only chip. I feel like I've been repeating this too often. > Ok, I just focus on ACPI, and keep DT code no changes. Cheers, Dongsheng
