Hi Biao, On 18-09-2018 04:24, biao huang wrote: > Hi Jose, Andrew, > Thanks for your comments. > Synopsys ip version in mt2712 is 4.21a, and followed ic will use 5.10a. > it seems GMAC4+ is a good choice. I'll try to extend STMMAC to support > mt2712. > Any tips about extend STMMAC? or anythings I should pay attention to? STMMAC already supports 4.21a and 5.10a. You only have to make sure that your regbank and descriptors matches. Thanks and Best Regards, Jose Miguel Abreu > > On Mon, 2018-09-17 at 17:18 +0100, Jose Abreu wrote: >> Hi Andrew, Biao, >> >> On 17-09-2018 16:24, Andrew Lunn wrote: >>> On Mon, Sep 17, 2018 at 02:29:21PM +0800, Biao Huang wrote: >>> >>> Adding in the STMMAC driver maintainers. >>> >>>> Ethernet in mt2712 is totally different from that in >>>> drivers/net/ethernet/mediatek/*, so we add new folder for mt2712 SoC. >>>> >>>> The mt2712 Ethernet IP is from Synopsys, and we notice that there is a >>>> reference driver in drivers/net/ethernet/synopsys/*. But >>>> 1. our version is only for 10/100/1000Mbps, not for 2.5/4/5Gbps. >>>> mt2712 Ethernet design is differnet from that in synopsys folder in many >>>> aspects, and some key features are not included in mt2712, such as rss >>>> and split header. At the same time, some features we need have not been >>>> implenmented in synopsys folder. >>> In general, we don't have two very similar drivers. We try to have one >>> driver. If the problem was just missing features in the stmmac driver, >>> you can add them. I doubt not supporting 2.5/4/5Gbps in your silicon >>> is an issue, since very few STMMAC devices have this. By split header, >>> do you mean support for TSO? That seems to be a gmac4 or newer >>> feature, but the driver supports not having tso support in hardware. >>> >>> Giuseppe, Alexandre, Jose: Please can you look at the proposed driver >>> and see how much it really differs from the STMMAC driver. >> Thanks for the cc Andrew, indeed this looks very similar and the >> register bank matches, by what I've seen, GMAC 4+. >> >>> How easy >>> would it be to extend stmmac it to support the mt2712? >> Very easy, as I've just done with XGMAC2. If Biao wants to expand >> stmmac functionality I'm all in favor! >> >> Thanks and Best Regards, >> Jose Miguel Abreu >> >>> Thanks >>> Andrew > Best Regards! > Biao >
