On 16.9.2018 12:12, Jonathan Cameron wrote: > On Fri, 14 Sep 2018 12:48:28 +0530 > Manish Narani <manish.narani@xxxxxxxxxx> wrote: > >> Add documentation for xilinx-ams driver. This contains information about >> various voltages and temperatures on PS (Processing System), PL >> (Programmable Logic) and AMS Control Block. >> >> Signed-off-by: Manish Narani <manish.narani@xxxxxxxxxx> > The more I look at this device the more I'm convinced it is very much a dedicated > hardware monitoring function, not a generic ADC sensing unit at all. > > Hmm. It is still fine to have it in IIO but you need to think in detail > about how you are going to interface this to hwmon via the iio-hwmon bridge. > > Some of the interface complexity should only really be apparent when we hit > hwmon perhaps rather than having so many different custom interfaces in IIO. > > Please also loop in the maintainers and lists for hwmon in the next > version so we can get their input. Isn't there iio-hwmon driver for this? Thanks, Michal