Hi, On 14/09/2018 11:44:26+0200, Quentin Schulz wrote: > In order to use GPIO4 as a GPIO, we need to mux it in this mode so let's > declare a new pinctrl DT node for it. > > Signed-off-by: Quentin Schulz <quentin.schulz@xxxxxxxxxxx> > --- > arch/mips/boot/dts/mscc/ocelot.dtsi | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/arch/mips/boot/dts/mscc/ocelot.dtsi b/arch/mips/boot/dts/mscc/ocelot.dtsi > index 8ce317c..b5c4c74 100644 > --- a/arch/mips/boot/dts/mscc/ocelot.dtsi > +++ b/arch/mips/boot/dts/mscc/ocelot.dtsi > @@ -182,6 +182,11 @@ > interrupts = <13>; > #interrupt-cells = <2>; > > + gpio4: gpio4 { > + pins = "GPIO_4"; > + function = "gpio"; > + }; > + For a GPIO, I would do that in the board dts because it is not used directly in the dtsi. > uart_pins: uart-pins { > pins = "GPIO_6", "GPIO_7"; > function = "uart"; > -- > git-series 0.9.1 -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com