On 13/09/2018 22:44:12+0200, Sam Ravnborg wrote: > > The boolean properties usually don't work well for RTCs because people > > usually want to keep any previous configuration that may have been done > > at the factory or in the bootloader so I would use: > > > > nxp,quartz_load_fF and this would be either 7000 or 12500. > We had is implmented like this (using pF) in the beginning but > then went for the simpler property. > Will add a fF property as you suggest and avoid breaking the existing drivers. > We will check a few of the boards to see if the current configuration > of the pcf8523 driver looks wrong, and if so we will print > the warnings as suggested. > > I think the above covers feedback on all patches. > And thanks for the feedback! > Hint: look at the cubox-i and the hummingboard schematics. I'm definitely not an analog expert but the two capacitors on the cubox-i are making me think that the setting should be different from the hummingboard. -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
