Re: [PATCH v2 18/23] v4l: fwnode: Use media bus type for bus parser selection

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Jacopo,

Thanks for the comments.

On Wed, Sep 12, 2018 at 05:15:05PM +0200, jacopo mondi wrote:
> Hi Sakari,
> 
> On Mon, Aug 27, 2018 at 12:29:55PM +0300, Sakari Ailus wrote:
> > Use the media bus types instead of the fwnode bus types internally. This
> > is the interface to the drivers as well, making the use of the fwnode bus
> > types more localised to the V4L2 fwnode framework.
> >
> 
> So basically now "v4l2_fwnode_bus_type" it is only used in a few
> places in v4l2-fwnode and has to be kept in sync with the bus types
> listed in the devicetree bindings documentation?

Correct.

> 
> Do you think it is still worth to keep around functions dealing with
> that enum type as "v4l2_fwnode_bus_type_to_string()" ?
> It is only used by a debug printout (without that much value added, as
> we can print out the integer parsed from the DT). In all other cases
> it can be converted to the corresponing v4l2_mbus_type immediately.

One of the aims of this patchset is to make debugging easier. A string is
more informative to the developers than a number, and for a few additional
lines of code I think that is justifiable.

I'll send v3 probably early tomorrow as I fixed a build issue;
V4L2_MBUS_UNKNOWN was used in one patch that preceded its introduction.

-- 
Regards,

Sakari Ailus
sakari.ailus@xxxxxxxxxxxxxxx



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux