On Wed, Sep 12, 2018 at 3:25 PM Guo Ren <ren_guo@xxxxxxxxx> wrote: > > Signed-off-by: Guo Ren <ren_guo@xxxxxxxxx> > diff --git a/arch/csky/boot/dts/qemu.dts b/arch/csky/boot/dts/qemu.dts > new file mode 100644 > index 0000000..c6643b1 > --- /dev/null > +++ b/arch/csky/boot/dts/qemu.dts > @@ -0,0 +1,77 @@ Did you consider renaming the file as I suggested? I think that would help in the long run when you get new qemu versions that have a different set of devices and that may provide their own dtbs. > diff --git a/arch/csky/include/asm/compat.h b/arch/csky/include/asm/compat.h > new file mode 100644 > index 0000000..59f9297 > --- /dev/null > +++ b/arch/csky/include/asm/compat.h > @@ -0,0 +1,11 @@ > +// SPDX-License-Identifier: GPL-2.0 > +// Copyright (C) 2018 Hangzhou C-SKY Microsystems co.,ltd. > + > +#ifndef __ASM_CSKY_COMPAT_H > +#define __ASM_CSKY_COMPAT_H > + > +#ifdef CONFIG_COMPAT > +#define COMPAT_UTS_MACHINE "csky\0\0" > +#endif > + > +#endif /* __ASM_CSKY_COMPAT_H */ Just noticed this one. I assume there won't be a csky64 architecture, so you can probably just delete this header. Arnd