On Mon, 2018-09-10 at 10:14 -0500, Rob Herring wrote: > On Mon, Sep 10, 2018 at 7:02 AM Lubomir Rintel <lkundrak@xxxxx> > wrote: > > > > There's apparently four of them on a MMP2. > > > > Signed-off-by: Lubomir Rintel <lkundrak@xxxxx> > > --- > > arch/arm/boot/dts/mmp2.dtsi | 40 > > +++++++++++++++++++++++++++++++++++++ > > 1 file changed, 40 insertions(+) > > > > diff --git a/arch/arm/boot/dts/mmp2.dtsi > > b/arch/arm/boot/dts/mmp2.dtsi > > index 766bbb8495b6..51d4a2d70db9 100644 > > --- a/arch/arm/boot/dts/mmp2.dtsi > > +++ b/arch/arm/boot/dts/mmp2.dtsi > > @@ -18,6 +18,10 @@ > > serial3 = &uart4; > > i2c0 = &twsi1; > > i2c1 = &twsi2; > > + sdhci0 = &mmc1; > > + sdhci1 = &mmc2; > > + sdhci2 = &mmc3; > > + sdhci3 = &mmc4; > > Please drop this. MMC nodes don't need an alias and if they did, > "sdhci" wouldn't be the name. Will do. I essentially just cargo-culted this, because I had no idea which devices need aliases. How do I decide whether an alias is needed? > > Rob Thank you, Lubo
