On Mon, Sep 10, 2018 at 9:56 AM Michal Simek <michal.simek@xxxxxxxxxx> wrote: > > On 5.9.2018 21:37, Rob Herring wrote: > > "device_type" use is deprecated for FDT though it has continued to be used > > for nodes like cpu nodes. Use of_get_cpu_node() instead which works using > > node names by default. This will allow the eventually removal of cpu > > device_type properties. > > > > Also, fix a leaked reference by adding a missing of_node_put. > > > > Cc: Michal Simek <monstr@xxxxxxxxx> > > Signed-off-by: Rob Herring <robh@xxxxxxxxxx> > > --- > > Please ack and I will take via the DT tree. This is dependent on the > > first 2 patches. > > I have tested it and it is align with the spec and all dtses generated > before 2015 will work without any issue. > In 2015 new device tree generator was introduced and it is not adding > reg property to cpu node which is required by this change. > This will be fixed but that means that all generated dtses from 2015 are > affected. Patch 2 was supposed to handle that case. However, it does expect that there should be an #address-cells equal to 0 in that case. Is that not a valid assumption? > That's why will be great if you can also change that pr_err message to > mentioned to also check reg property to give users a chance to fix it > properly. Error log below. I don't think breaking users is good. I could make this a find by path (/cpus/cpu) instead or just drop it for microblaze. It doesn't really affect my plans for removing device_node.type ptr. Rob > Anyway here is my > Tested-by: Michal Simek <michal.simek@xxxxxxxxxx> > > Thanks, > Michal
