Hi Sergie, Thanks for the patch > -----Original Message----- > From: devicetree-owner@xxxxxxxxxxxxxxx <devicetree- > owner@xxxxxxxxxxxxxxx> On Behalf Of Sergei Shtylyov > Sent: 05 September 2018 21:32 > To: Daniel Lezcano <daniel.lezcano@xxxxxxxxxx>; Thomas Gleixner > <tglx@xxxxxxxxxxxxx>; Rob Herring <robh+dt@xxxxxxxxxx>; > devicetree@xxxxxxxxxxxxxxx > Cc: linux-renesas-soc@xxxxxxxxxxxxxxx; linux-sh@xxxxxxxxxxxxxxx > Subject: [PATCH 2/2] clocksource: sh_cmt: add R-Car gen3 support > > Add support for the R-Car gen3 CMT0 and CMT1 bindings -- they seem to be > the same CMT0 and CMT1 as in R-Car gen2 SoCs. Also document R8A779{7|8} > bindings as these are the R-Car gen3 SoCs for which the initial support was > done. > > Signed-off-by: Sergei Shtylyov <sergei.shtylyov@xxxxxxxxxxxxxxxxxx> > > --- > Documentation/devicetree/bindings/timer/renesas,cmt.txt | 7 +++++++ > drivers/clocksource/sh_cmt.c | 8 ++++++++ > 2 files changed, 15 insertions(+) > > Index: renesas/Documentation/devicetree/bindings/timer/renesas,cmt.txt > ========================================================== > ========= > --- renesas.orig/Documentation/devicetree/bindings/timer/renesas,cmt.txt > +++ renesas/Documentation/devicetree/bindings/timer/renesas,cmt.txt > @@ -34,6 +34,10 @@ Required Properties: > - "renesas,r8a7793-cmt1" for the 48-bit CMT1 device included in r8a7793. > - "renesas,r8a7794-cmt0" for the 32-bit CMT0 device included in r8a7794. > - "renesas,r8a7794-cmt1" for the 48-bit CMT1 device included in r8a7794. > + - "renesas,r8a77970-cmt0" for the 32-bit CMT0 device included in > r8a77970. > + - "renesas,r8a77970-cmt1" for the 48-bit CMT1 device included in > r8a77970. > + - "renesas,r8a77980-cmt0" for the 32-bit CMT0 device included in > r8a77980. > + - "renesas,r8a77980-cmt1" for the 48-bit CMT1 device included in > r8a77980. > > - "renesas,rcar-gen2-cmt0" for 32-bit CMT0 devices included in R-Car Gen2 > and RZ/G1. > @@ -41,6 +45,9 @@ Required Properties: > and RZ/G1. > These are fallbacks for r8a73a4, R-Car Gen2 and RZ/G1 > entries > listed above. > + - "renesas,rcar-gen3-cmt0" for 32-bit CMT0 devices included in R-Car > Gen3. > + - "renesas,rcar-gen3-cmt1" for 48-bit CMT1 devices included in R-Car Do we need to mention CMT1/2/3 instead of CMT1, since CMT2/3 is similar to CMT1? > Gen3. > +These are fallbacks for R-Car Gen3 entries listed above. > > - reg: base address and length of the registers block for the timer module. > - interrupts: interrupt-specifier for the timer, one per channel. > Index: renesas/drivers/clocksource/sh_cmt.c > ========================================================== > ========= > --- renesas.orig/drivers/clocksource/sh_cmt.c > +++ renesas/drivers/clocksource/sh_cmt.c > @@ -945,6 +945,14 @@ static const struct of_device_id sh_cmt_ > .compatible = "renesas,rcar-gen2-cmt1", > .data = &sh_cmt_info[SH_CMT1_RCAR_GEN2] > }, > +{ > +.compatible = "renesas,rcar-gen3-cmt0", > +.data = &sh_cmt_info[SH_CMT0_RCAR_GEN2] > +}, > +{ > +.compatible = "renesas,rcar-gen3-cmt1", > +.data = &sh_cmt_info[SH_CMT1_RCAR_GEN2] > +}, > { } > }; > MODULE_DEVICE_TABLE(of, sh_cmt_of_table); regards, Biju Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.