On Wed, Sep 5, 2018 at 12:33 PM, Maxime Ripard <maxime.ripard@xxxxxxxxxxx> wrote: > On Tue, Sep 04, 2018 at 10:06:06PM +0530, Jagan Teki wrote: >> Allwinner SoC like SUN8I and SUN50I has DE2 CCU so enable them >> as default. >> >> Signed-off-by: Jagan Teki <jagan@xxxxxxxxxxxxxxxxxxxx> >> --- >> Changes for v4, v3: >> - none >> Changes for v2: >> - Enable for MACH_SUN8I >> >> drivers/clk/sunxi-ng/Kconfig | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/drivers/clk/sunxi-ng/Kconfig b/drivers/clk/sunxi-ng/Kconfig >> index 826674d090fd..e20182aa9748 100644 >> --- a/drivers/clk/sunxi-ng/Kconfig >> +++ b/drivers/clk/sunxi-ng/Kconfig >> @@ -63,6 +63,8 @@ config SUN8I_V3S_CCU >> >> config SUN8I_DE2_CCU >> bool "Support for the Allwinner SoCs DE2 CCU" >> + default MACH_SUN8I || (ARM64 && ARCH_SUNXI) >> + depends on DRM_SUN4I && (MACH_SUN8I || (ARM64 && ARCH_SUNXI)) > > I don't see why there's a dependency on the DRM driver. I'm pretty > sure this would even break simplefb. Ok, got it. I will drop the depends on just add default.