Hi Rob > -----Original Message----- > From: Rob Herring <robh@xxxxxxxxxx> > Sent: Tuesday, September 04, 2018 09:25 > To: Ran Wang <ran.wang_1@xxxxxxx> > Cc: Leo Li <leoyang.li@xxxxxxx>; Mark Rutland <mark.rutland@xxxxxxx>; > linuxppc-dev@xxxxxxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; > devicetree@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx > Subject: Re: [PATCH 2/3] Documentation: dt: binding: fsl: update property > description for RCPM > > On Fri, Aug 31, 2018 at 11:52:18AM +0800, Ran Wang wrote: > > Add property 'big-endian' and supportted IP's configuration info. > > Remove property 'fsl,#rcpm-wakeup-cell'. > > "dt-bindings: soc: ..." for the subject > > It is obvious reading the diff you are removing fsl,#rcpm-wakeup-cell. > What is not obvious is why? The commit msg should answer that. Sure, I will add this in next version patch. > You also are mixing several things in this patch like adding ls1012 which you > don't mention. Please split. Got it, will split them and add more information in next version. Ran > > > > Signed-off-by: Ran Wang <ran.wang_1@xxxxxxx> > > --- > > Documentation/devicetree/bindings/soc/fsl/rcpm.txt | 42 ++++++----------- > -- > > 1 files changed, 13 insertions(+), 29 deletions(-)