On 09/03/2018 09:46 PM, Florian Fainelli wrote: > > > On 9/1/2018 5:04 AM, Hauke Mehrtens wrote: >> This adds the binding for the PMAC core between the CPU and the GSWIP >> switch found on the xrx200 / VR9 Lantiq / Intel SoC. >> >> Signed-off-by: Hauke Mehrtens <hauke@xxxxxxxxxx> >> Cc: devicetree@xxxxxxxxxxxxxxx >> --- >> .../devicetree/bindings/net/lantiq,xrx200-net.txt | 21 >> +++++++++++++++++++++ >> 1 file changed, 21 insertions(+) >> create mode 100644 >> Documentation/devicetree/bindings/net/lantiq,xrx200-net.txt >> >> diff --git >> a/Documentation/devicetree/bindings/net/lantiq,xrx200-net.txt >> b/Documentation/devicetree/bindings/net/lantiq,xrx200-net.txt >> new file mode 100644 >> index 000000000000..8a2fe5200cdc >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/net/lantiq,xrx200-net.txt >> @@ -0,0 +1,21 @@ >> +Lantiq xRX200 GSWIP PMAC Ethernet driver >> +================================== >> + >> +Required properties: >> + >> +- compatible : "lantiq,xrx200-net" for the PMAC of the embedded >> + : GSWIP in the xXR200 >> +- reg : memory range of the PMAC core inside of the GSWIP core >> +- interrupts : TX and RX DMA interrupts. Use interrupt-names "tx" for >> + : the TX interrupt and "rx" for the RX interrupt. > > You would likely want to document that the order should be strict, that > is TX interrupt first and RX interrupt second, but other than that: > > Reviewed-by: Florian Fainelli <f.fainelli@xxxxxxxxx> Currently this is fetched based on the name like this: platform_get_irq_byname(pdev, "rx"); I do not care about the order, just interrupt-names must match. Hauke
Attachment:
signature.asc
Description: OpenPGP digital signature