Hi Rob, Thanks for the providing the comments... Please find my response inline... > -----Original Message----- > From: Rob Herring [mailto:robh@xxxxxxxxxx] > Sent: Tuesday, August 14, 2018 9:49 PM > To: Nava kishore Manne <navam@xxxxxxxxxx> > Cc: mark.rutland@xxxxxxx; Michal Simek <michals@xxxxxxxxxx>; Soren > Brinkmann <sorenb@xxxxxxxxxx>; atull@xxxxxxxxxxxxxxxxxxxxx; > moritz.fischer@xxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; linux-arm- > kernel@xxxxxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; Appana Durga > Kedareswara Rao <appanad@xxxxxxxxxx>; chinnikishore369@xxxxxxxxx; Nava > kishore Manne <navam@xxxxxxxxxx> > Subject: Re: [RFC PATCH 1/2] ARM: dt: fpga: Added binding docs for Xilinx > zynqmp FPGA manager > > On Wed, Aug 01, 2018 at 03:34:56PM +0530, Nava kishore Manne wrote: > > New bindings document for zynqmp fpga manager. > > > > Signed-off-by: Nava kishore Manne <navam@xxxxxxxxxx> > > --- > > .../devicetree/bindings/fpga/xlnx,zynqmp-pcap-fpga.txt | 9 +++++++++ > > 1 file changed, 9 insertions(+) > > create mode 100644 > > Documentation/devicetree/bindings/fpga/xlnx,zynqmp-pcap-fpga.txt > > > > diff --git > > a/Documentation/devicetree/bindings/fpga/xlnx,zynqmp-pcap-fpga.txt > > b/Documentation/devicetree/bindings/fpga/xlnx,zynqmp-pcap-fpga.txt > > new file mode 100644 > > index 000000000000..0eac747747f5 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/fpga/xlnx,zynqmp-pcap-fpga.txt > > @@ -0,0 +1,9 @@ > > +Xilinx Zynqmp FPGA Manager > > + > > +Required properties: > > +- compatible: should contain "xlnx,zynqmp-pcap-fpga" > > + > > +Example: > > + pcap: pcap@00 { > > + compatible = "xlnx,zynqmp-pcap-fpga"; > > How is this accessed? Via firmware interface? If so, need to define it is a child of > the firmware node. Yes, it's uses firmware interface... Will fix it in the next version. Regards, Navakishore.