Hi, On 03/03/2014 06:51 PM, Joe Perches wrote: > On Mon, 2014-03-03 at 11:44 +0100, Florian Vaussard wrote: >> Looking at the current documentation, the list of these generic >> placeholders is pretty short: >> >> $ git grep ',<.*>-' Documentation/devicetree/bindings/ | \ >> grep -P -o ',<.*?>-' | grep -P -o '<.*>' | sort | uniq >> >> <board> >> <chip> >> <chip name> >> <mcu-chip> >> <processor> >> <soc> >> <SOC> >> <soc-family> >> >> so '[a-zA-Z0-9-]+' seems more reasonable indeed. > > The <mcu-chip> use seems as if it's 2 wildcards > > fsl,<mcu-chip>-<board> > > I'm not sure that could work with the current > checkpatch code. > I don't think it is desirable to make it work with the current checkpatch code, as it is not enough constrained. For example, it allows any compatible "fsl,foo-bar" to match, which opens the door for abuse. We should have at least one fixed pattern. > There's a space in "<chip name>" that should > probably be replaced by "<chip-name>" or just > "<chip>" for consistency. > Sure, some cleaning could be necessary. I will see what I can do. >> $compat2 =~ s/\,[a-zA-Z0-9]*\-/<\.\*>\-/g; > > hand-escaped, not necessary if using "\Q$compat2\E" > I wasn't aware of this, thanks. > Anyway, if either you or Rob think it appropriate to > submit a patch for either of the things I mentioned > in the first place: > >> o Look for ".compatible = "foo" strings in .c and .h files >> o Improve the vendor name match in vendor-prefix.txt by only >> matching the exact vendor name at the beginning of lines. > > or any of the stuff above here, please do. > As you already sent a patch for these, I will include it in the v3 of this series. I see another problem: with the current regexp patterns, we have enforced the use of a limited character set. But if one uses an exotic character (even a simple space ' '), no warning will be produced at all. We may check that we have at least one matching test, and throw a warning otherwise. But this opens the question of enforcing the characters used in compatible strings, where there is no strict guideline AFAIK. Regards, Florian -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
