Mark, On 29/08/2018 16:15:02+0100, Mark Brown wrote: > On Wed, Aug 29, 2018 at 06:09:55PM +0300, Andy Shevchenko wrote: > > ----- Forwarded message from Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> ----- > > > > Date: Wed, 29 Aug 2018 18:08:31 +0300 > > From: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> > > To: Alexandre Belloni <alexandre.belloni@xxxxxxxxxxx> > > Subject: Re: [PATCH] spi: dw-mmio: add MSCC Jaguar2 support > > User-Agent: Mutt/1.10.1 (2018-07-13) > > > > On Wed, Aug 29, 2018 at 02:45:48PM +0200, Alexandre Belloni wrote: > > > Unfortunately, the Jaguar2 CPU_SYSTEM_CTRL register set has a different > > > layout than the Ocelot one. Handle that while keeping most of the code > > > common. > > > > > -#define OCELOT_IF_SI_OWNER_MASK GENMASK(5, 4) > > > > > + 0x3 << if_si_owner_offset, > > > > Perhaps, > > > > #define MSCC_IF_SI_OWNER_MASK GENMASK(1, 0) > > Oops, sorry - that seems to have been eaten somewhere. :( Do you want me to send a new version or a patch that you could squash in the second one? -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
