RE: [PATCH Resend 2/2] mfd: da9055: Add DT binding documentation for PMIC

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On Tue, 05 Mar 2014 02:40:38 +0000, Lee Jones wrote:

> > Signed-off-by: Adam Thomson <Adam.Thomson.Opensource@xxxxxxxxxxx>
> > Acked-by: Mark Brown <broonie@xxxxxxxxxx>
> 
> As this has Mark's ack, I'd be happy to apply the patch if you correct
> a couple of nits.

Yep. No problem.

> > +Example:
> > +
> > +	pmic: da9055-pmic@5a {
> > +		compatible = "dlg,da9055-pmic";
> > +		reg = <0x5a>;
> > +		interrupt-parent = <&intc>;
> > +		interrupts = <5 0x8>;
> 
> I'd prefer if you used the #defines in:
>     dt-bindings/interrupt-controller/irq.h

Fine. Will do that.

> > +			buck2: BUCK2 {
> > +				regulator-min-microvolt = <925000>;
> > +				regulator-max-microvolt = <2500000>;
> > +			};
> 
> New line here.

Will remove it.
��.n��������+%������w��{.n����z�{��ܨ}���Ơz�j:+v�����w����ޙ��&�)ߡ�a����z�ޗ���ݢj��w�f





[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]
  Powered by Linux