Hi Michal, Am Dienstag, 28. August 2018, 10:31:15 CEST schrieb Michal Vokáč: > On 28.8.2018 10:12, Sandy Huang wrote: > > This path add support rv1108 and px30 rgb output interface driver. > > Hi Sandy, > Seems like you forgot to address Rob's comment regarding the "driver" word. > Also fix the typo: s/path/patch > The subject could be improved as well: s/devicetree\/bindings/dt-bindings We actually honored Rob's bigger concern of the rgb output not being an actual device backed by programmable hardware and moved the rgb output inside the driver, see v7 of the patchset [0]. Heiko [0] https://patchwork.freedesktop.org/patch/246297/ https://patchwork.freedesktop.org/patch/246298/ https://patchwork.freedesktop.org/patch/246299/