Re: [PATCH] arm64: dts: remove big-endian filed from IFC controller

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Aug 28, 2018 at 2:02 AM Prabhakar Kushwaha
<prabhakar.kushwaha@xxxxxxx> wrote:
>
> As per IFC binding, Absence of "little-endian" field causes registers
> access in big-endian mode.
> So no need to set explicit big-endian field IFC node for LS1043A and
> LS1046A.
>
> Signed-off-by: Prabhakar Kushwaha <prabhakar.kushwaha@xxxxxxx>
> ---
>  arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi | 2 +-
>  arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi | 3 ++-
>  2 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi
> index b9f5d2ff4ff2..68af84a8ade8 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi
> @@ -3,6 +3,7 @@
>   * Device Tree Include file for Freescale Layerscape-1043A family SoC.
>   *
>   * Copyright 2014-2015 Freescale Semiconductor, Inc.
> + * Copyright 2018 NXP
>   *
>   * Mingkai Hu <Mingkai.hu@xxxxxxxxxxxxx>
>   */
> @@ -280,7 +281,6 @@
>                 ifc: ifc@1530000 {
>                         compatible = "fsl,ifc", "simple-bus";
>                         reg = <0x0 0x1530000 0x0 0x10000>;
> -                       big-endian;
>                         interrupts = <0 43 0x4>;
>                 };
>
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
> index 65ce1c3cb568..9f5acb4dfaf3 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1046a.dtsi
> @@ -4,6 +4,8 @@
>   *
>   * Copyright 2016 Freescale Semiconductor, Inc.
>   *
> + * Copyright 2018 NXP
> + *

Probably better to align with the other files to not have empty line
between copyright claims?

>   * Mingkai Hu <mingkai.hu@xxxxxxx>
>   */
>
> @@ -198,7 +200,6 @@
>                 ifc: ifc@1530000 {
>                         compatible = "fsl,ifc", "simple-bus";
>                         reg = <0x0 0x1530000 0x0 0x10000>;
> -                       big-endian;
>                         interrupts = <GIC_SPI 43 IRQ_TYPE_LEVEL_HIGH>;
>                 };
>
> --
> 2.14.1
>



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux