Hi leo > -----Original Message----- > From: Li Yang <leoyang.li@xxxxxxx> > Sent: Tuesday, August 28, 2018 1:00 AM > To: Prabhakar Kushwaha <prabhakar.kushwaha@xxxxxxx> > Cc: open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS > <devicetree@xxxxxxxxxxxxxxx>; Rob Herring <robh@xxxxxxxxxx>; Mark > Rutland <mark.rutland@xxxxxxx>; Shawn Guo <shawnguo@xxxxxxxxxx>; > moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE <linux-arm- > kernel@xxxxxxxxxxxxxxxxxxx>; Alison Wang <alison.wang@xxxxxxx>; Jagdish > Gediya <jagdish.gediya@xxxxxxx> > Subject: Re: [PATCH 1/3] ARM: dts: Add big-endian for IFC on LS1021A > > On Fri, Aug 17, 2018 at 5:20 AM Prabhakar Kushwaha > <prabhakar.kushwaha@xxxxxxx> wrote: > > > > Register space of IFC controller is big-endian. > > > > So add big-endian in IFC device tree node. > > Is this change necessary? The current binding of IFC says: > > - little-endian : If this property is absent, the big-endian mode will > be in use as default for registers. > I agree.. this patch is not required. But your comments has remind me to remove big-endian property from ls1043a and ls0146a also under IFC controller. Thanks --pk