Hi Jonathan, On 25 August 2018 at 16:43, Jonathan Cameron <jic23@xxxxxxxxxx> wrote: > On Fri, 24 Aug 2018 17:53:16 +0800 > Baolin Wang <baolin.wang@xxxxxxxxxx> wrote: > >> This patch adds support to read calibration values from the eFuse >> controller to calibrate the ADC channel scales, which can make ADC >> sample data more accurate. >> >> Signed-off-by: Baolin Wang <baolin.wang@xxxxxxxxxx> > This looks good to me. I'll leave it for now though given open questions > on patch 1 and to allow others time to comment on this if they wish - > particularly as it includes a binding addition. Thanks for your reviewing. But after more testing, we found one issue when reading calibration data from efuse, which is not always 4 bytes (sizeof(u32)). So I will change to use nvmem_cell_read() instead of nvmem_cell_read_u32() in next version. -- Baolin Wang Best Regards
