RE: [PATCH] clk: renesas: cpg-mssr: Add R7S9210 support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Geert,

On Monday, August 27, 2018 1, Geert Uytterhoeven wrote:
> Given the differences, and the limited amount of RAM on RZ/A2, I think you
> would be better off with a separate renesas-cpg-stbcr driver, and an
> r7s9210-cpg-stbcr counterpart.

I went and measured the amount of RAM being used by the driver 
(allocated during boot when the driver is loaded and probed), and it's only 8KB. 
That's not really much compared to other drivers and subsystems being 
loaded in the system. Of course RZ/A tries to be RAM sensitive...but 8KB 
for a clock driver is not my biggest concern.

So with that said, I could add in a driver option to not register the 
reset controller. And, also make a macro so users can specify "36" instead
of "306" in the DT.
And then, I no longer have to worry about duplicate code (2 drivers do 
almost the same thing).

What do you think?
Were you expecting the driver to allocate more than 8K of RAM on boot?

Thanks,
Chris





[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux