Hi Sébastien, On Fri, Aug 24, 2018 at 1:32 PM Sébastien Szymanski <sebastien.szymanski@xxxxxxxxxxxx> wrote: > > Add weim node for i.MX6UL SOC. > > Signed-off-by: Sébastien Szymanski <sebastien.szymanski@xxxxxxxxxxxx> > --- > arch/arm/boot/dts/imx6ul.dtsi | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/arch/arm/boot/dts/imx6ul.dtsi b/arch/arm/boot/dts/imx6ul.dtsi > index 47a3453a4211..7b00efd93d18 100644 > --- a/arch/arm/boot/dts/imx6ul.dtsi > +++ b/arch/arm/boot/dts/imx6ul.dtsi > @@ -912,6 +912,17 @@ > reg = <0x021b0000 0x4000>; > }; > > + weim: weim@21b8000 { > + #address-cells = <2>; > + #size-cells = <1>; > + compatible = "fsl,imx6ul-weim", "fsl,imx6q-weim"; > + reg = <0x021b8000 0x4000>; > + interrupts = <0 14 IRQ_TYPE_LEVEL_HIGH>; Looks good. Only a minor nit: for consistency please use: interrupts = <GIC_SPI 14 IRQ_TYPE_LEVEL_HIGH>; Reviewed-by: Fabio Estevam <fabio.estevam@xxxxxxx>