Hi, On Mon, Aug 20, 2018 at 11:18 AM, Stephen Boyd <swboyd@xxxxxxxxxxxx> wrote: > Quoting Douglas Anderson (2018-08-10 14:51:49) >> @@ -20,6 +21,450 @@ >> chosen { >> stdout-path = "serial0:115200n8"; >> }; >> + >> + vph_pwr: vph-pwr-regulator { >> + compatible = "regulator-fixed"; >> + regulator-name = "vph_pwr"; >> + regulator-min-microvolt = <3700000>; >> + regulator-max-microvolt = <3700000>; >> + }; >> + >> + /* >> + * Apparently RPMh does not provide support for PM8998 S4 because it >> + * is always-on; model it as a fixed regulator. >> + */ >> + vreg_s4a_1p8: pm8998-smps4 { >> + compatible = "regulator-fixed"; >> + regulator-name = "vreg_s4a_1p8"; >> + >> + regulator-min-microvolt = <1800000>; >> + regulator-max-microvolt = <1800000>; >> + >> + regulator-always-on; >> + regulator-boot-on; > > Can vin be vph_pwr? That would properly model this. Yes, good suggestion. Fixed in v3. -Doug