On Fri 27 Jul 08:28 PDT 2018, Sibi Sankar wrote: > In the presence of a PDC block working with subsystem RSC, > assert/deassert PDC restart in modem start/stop path. > > Signed-off-by: Sibi Sankar <sibis@xxxxxxxxxxxxxx> > --- > .../bindings/remoteproc/qcom,q6v5.txt | 4 +++ > drivers/remoteproc/qcom_q6v5_pil.c | 27 ++++++++++++++++--- > 2 files changed, 27 insertions(+), 4 deletions(-) > > diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,q6v5.txt b/Documentation/devicetree/bindings/remoteproc/qcom,q6v5.txt > index 601dd9f389aa..124fb1dc6fb8 100644 > --- a/Documentation/devicetree/bindings/remoteproc/qcom,q6v5.txt > +++ b/Documentation/devicetree/bindings/remoteproc/qcom,q6v5.txt > @@ -51,6 +51,8 @@ on the Qualcomm Hexagon core. > Usage: required > Value type: <phandle> > Definition: reference to the reset-controller for the modem sub-system > + reference to the list of 2 reset-controllers for the modem > + sub-system on SDM845 SoCs > reference to the list of 3 reset-controllers for the > wcss sub-system > > @@ -58,6 +60,8 @@ on the Qualcomm Hexagon core. > Usage: required > Value type: <stringlist> > Definition: must be "mss_restart" for the modem sub-system > + Definition: must be "mss_restart", "pdc_restart" for the modem > + sub-system on SDM845 SoCs > Definition: must be "wcss_aon_reset", "wcss_reset", "wcss_q6_reset" > for the wcss syb-system Seems like we got an additional "Definition:" added here as we added the wcss. Please don't add another one. The rest looks good. Regards, Bjorn