Hi Rob, > > > +Clock bindings based on SCU Message Protocol > > > +------------------------------------------------------------ > > > + > > > +This binding uses the common clock binding[1]. > > > + > > > +Required properties: > > > +- compatible: Should be "fsl,imx8qxp-clock". > > > +- #clock-cells: Should be 1. Contains the Clock ID value. > > > > There was a recent patch adding input clocks to other i.MX CCM bindings. > > Is that needed here? > > > > Will double check it, thanks for reminder. It should work for mx8 as well. I will add them like below: +- clocks: List of clock specifiers, must contain an entry for + each required entry in clock-names +- clock-names: Should include entries "xtal_32KHz", "xtal_24MHz" Thanks for the suggestion. Regards Dong Aisheng