On Mon, 20 Aug 2018 16:07:37 +0200 Maxime Ripard <maxime.ripard@xxxxxxxxxxx> wrote: > On Mon, Aug 20, 2018 at 07:41:22AM -0600, Rob Herring wrote: > > On Mon, Aug 20, 2018 at 5:17 AM Maxime Ripard <maxime.ripard@xxxxxxxxxxx> wrote: > > > > > > On Sat, Aug 04, 2018 at 09:03:49AM +0200, Emmanuel Vadot wrote: > > > > This patch adds documentation for Device-Tree bindings for the Allwinner > > > > Thermal Sensor Controller found on the H3, H5 and A64 SoCs > > > > > > > > Signed-off-by: Emmanuel Vadot <manu@xxxxxxxxxxx> > > > > > > I'm not going to merge a binding for a device that doesn't have any > > > driver implemented at the moment in Linux. > > > > I'll take it then. Linux is not the only DT client. > > Then don't complain if we ever have to break the ABI. We never tested > that hardware, never had any code running on it, and it *will* cause > some issues. For example, the calibration data have never been used > and how they should be represented have never been described, since no > one ever actually tried to use it. > > And sure, Linux is not the only DT client. Just like FreeBSD isn't. > > Maxime Maxime, What kind of data would you need for me to make things better ? We have the driver in FreeBSD for almost two years now, whne I started to see how to upstream it I noticed a lot of problems and spent 4 or 5 days to try on all the SoCs mentionned in the serie, the only SoC I didn't include it the A83T as for some reason I couldn't make the driver work. I just hope that you understand that we cannot wait for Linux to have a driver to have some bindings. Cheers, -- Emmanuel Vadot <manu@xxxxxxxxxxxxxxxx> <manu@xxxxxxxxxxx>
