Hi, this email is from Rob's (experimental) review bot. I found a couple of common problems with your patch. Please see below. On Wed, 15 Aug 2018 16:51:23 +0100, Lad Prabhakar wrote: > From: "Lad, Prabhakar" <prabhakar.csengg@xxxxxxxxx> > > ksz9477 is superset of ksz9xx series, driver just works > out of the box for ksz9897 chip with this patch. > > Signed-off-by: Lad, Prabhakar <prabhakar.csengg@xxxxxxxxx> The preferred subject prefix is "dt-bindings: <binding dir>: ...". > --- > Documentation/devicetree/bindings/net/dsa/ksz.txt | 4 +++- > drivers/net/dsa/microchip/ksz_common.c | 9 +++++++++ > drivers/net/dsa/microchip/ksz_spi.c | 1 + > 3 files changed, 13 insertions(+), 1 deletion(-) > DT bindings (including binding headers) should be a separate patch. See Documentation/devicetree/bindings/submitting-patches.txt.