On Lu, 2018-08-06 at 15:39 +0100, Mark Brown wrote: > On Mon, Aug 06, 2018 at 03:04:44PM +0300, Stefan Popa wrote: > > > > > + if (!regmap_volatile(map, reg) || !regmap_readable(map, reg)) > > { > > + ret = -EINVAL; > > + goto out_unlock; > > + } > I suggested having an explicit operation to check if a register supports > this mode of operation when I reviewed an earlier version, I didn't > notice a reply on that? Hi Mark, Sorry, I got confused about what needs to be done. Should I add a new field to the regmap_config struct which will be checked during the function call? Something like can_multi_write? How do you suggest it should be called? Is readable_noinc_reg ok? Thank you! Stefan��.n��������+%������w��{.n����z�{��ܨ}���Ơz�j:+v�����w����ޙ��&�)ߡ�a����z�ޗ���ݢj��w�f